Moved global collections into the Client class#1
Moved global collections into the Client class#1xperroni wants to merge 1 commit intoMarkusPiotrowski:mainfrom
Conversation
Previously, the Client class relied on global collections to exchange data
with the Android callback objects. This would cause problems when trying
to simultaneously connect to multiple devices. Fixed by moving the global
collections into the Client class.
A note about member naming conventions: in Python, "true" private members
are prefixed by two underscores ("__"), while members prefixed with only one
underscore ("_") are still public, but by convention should not be accessed
by external code unless strictly necessary.The committed changes follow this
convention, e.g. Client._received_data is kept accessible so it can be modified
by Android callbacks, while Client.__services is only accessed from inside the
class itself.
References:
* https://docs.python.org/3/tutorial/classes.html#private-variables
Signed-off-by: Helio Perroni Filho <xperroni@gmail.com>
|
@xperroni Thank you very much for your contribution. Clearly, you know more about programming than me (being a hobbyist programmer). Still, I want to keep understanding my code and for the moment I see more changes that you introduce than that are explained in your starting comment. So it would be nice if you can explain a little bit more what you changed for what reason. I'm aware about Python's "private" conventions and I don't care about having 'real' private members, Therefore, I usually stick to the single underscore pattern. Also, I do hesitate to import |
|
Hi Markus,
Of course. Apart from moving the global collections inside the However, because I think that's all worth mentioning on this commit, but let me know if anything else caught your attention.
I suppose "your mileage my vary", but I have been using it quite extensively while working on an Android project, and I haven't really noticed any performance issues. In any case, in a typical application the BLE client will rarely connect / disconnect more than a few times during the application's lifetime, so I don't see it becoming an important factor in this case. |
|
Included in PR #8 Thank you! |
2 participants
Previously, the
Clientclass relied on global collections to exchange data with the Android callback objects. This would cause problems when trying to simultaneously connect to multiple devices. Fixed by moving the global collections into theClientclass.A note about member naming conventions: in Python, "true" private members are prefixed by two underscores (
__), while members prefixed with only one underscore (_) are still public, but by convention should not be accessed by external code unless strictly necessary. The committed changes follow this convention, e.g.Client._received_datais kept accessible so it can be modified by Android callbacks, whileClient.__servicesis only accessed from inside the class itself.References: